Skip to content

Add test for composer files autoload#262

Open
simPod wants to merge 1 commit intomaglnet:4.0.xfrom
simPod:included
Open

Add test for composer files autoload#262
simPod wants to merge 1 commit intomaglnet:4.0.xfrom
simPod:included

Conversation

@simPod
Copy link
Contributor

@simPod simPod commented Apr 14, 2021

I think this case should not fail while it currently does.

I was not sure how and whether to fix it though, so I added a reproducible test case.

@Ocramius
Copy link
Collaborator

Ocramius commented Apr 14, 2021

LogicException: There were no symbols found, please check your configuration.

Fairly sure this needs fixing, although it's really annoying to support all the formats of classmap, autoload-files, etc.

FWIW, this has been implemented in detail in roave/better-reflection at https://github.com/Roave/BetterReflection/blob/478ed89e695cbff3ac037ccaa713cb56aee359b4/src/SourceLocator/Type/Composer/Factory/MakeLocatorForComposerJson.php#L80-L122

EDIT: that's mostly a small rant about the fact that we keep hitting these limitations because:

  1. nobody is really helping bringing roave/better-reflection up to PHP 8 compat @_@
  2. this roave/better-reflection thing keeps regularly popping up in this library - would remove a lot of code

@simPod
Copy link
Contributor Author

simPod commented Apr 20, 2021

@Ocramius so the proper solution to this would be to work on roave/better-reflection first, right?

@Ocramius
Copy link
Collaborator

@simPod not sure tbh - could be, just unsure about effort

@simPod simPod changed the base branch from 3.3.x to 4.0.x December 13, 2021 15:31
@Ocramius
Copy link
Collaborator

Ocramius commented Dec 13, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants