Refactor PushButtonEditor fields to use addNewButton pattern

[Copilot]

Replaces deprecated PdmField + PdmUiPushButtonEditorAttribute pattern with direct addNewButton() calls in 13 classes.

Pattern Change

Before:

// Header
caf::PdmField<bool> m_buttonField;

// Constructor
CAF_PDM_InitField(&m_buttonField, "ButtonField", false, "");
m_buttonField.uiCapability()->setUiEditorTypeName(caf::PdmUiPushButtonEditor::uiEditorTypeName());

// defineEditorAttribute
if (field == &m_buttonField) {
    auto* attrib = dynamic_cast<caf::PdmUiPushButtonEditorAttribute*>(attribute);
    attrib->m_buttonText = "Button Text";
}

// fieldChangedByUi
if (changedField == &m_buttonField) {
    performAction();
    m_buttonField = false;
}

After:

// defineUiOrdering only
uiOrdering.addNewButton("Button Text", [this]() { performAction(); });

Changes

• 13 classes refactored: RiaMemoryCleanup, RimFracture, RimCloudDataSourceCollection, RimFlowCharacteristicsPlot, RimWellAllocationOverTimePlot, RimGeoMechCase, RimGeoMechFaultReactivationResult, RimStatisticsContourMap, RimDeltaSummaryEnsemble, RimEnsembleCurveFilter, RimEnsembleCurveFilterCollection, RimEnsembleCurveSet, RicSummaryPlotEditorUi

• Removed:

  • 23 PdmField button declarations from headers
  • Button initialization from constructors
  • defineEditorAttribute methods or button-specific code
  • Button state reset logic from fieldChangedByUi

• Added:

  • addNewButton() calls in defineUiOrdering with lambda callbacks
  • Helper methods for complex button actions (e.g., RimFlowCharacteristicsPlot::onShowRegionClicked)

Net reduction: ~150 lines of boilerplate code.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Refactoring Guide: PushButtonEditor Fields</issue_title>
<issue_description>## The following pattern is used in some classes

A PdmField m_pushbButton is used to display a push button.

This code is used in defineEditorAttributes to modify the appearance of the button.

 if ( field == &m_pushbButton )
    {
        if ( auto attrib = dynamic_cast<caf::PdmUiPushButtonEditorAttribute*>( attribute ) )
        {
            attrib->m_buttonText = "Edit";
        }
    }

The state of the field is reset in fieldChangedByUi.

Replace this pattern with a dynamic push button like this:

        group->addNewButton( "Edit",
                             [this]() { RimPolygonTools::activate3dEditOfPolygonInView( m_cellFilterPolygon(), this ); },
                             { .newRow = false } );

Keep the following classes unchanged

RimUserDefinedPolylinesAnnotation
RimExtrudedCurveIntersection
RimPolygonInView
RimGridCalculationVariable
RimSummaryCalculationVariable

Refactor the following classes

Here is a list of candidates to refactor. Mark them as complete when done.

RiaMemoryCleanup
RicSummaryPlotEditorUi
RimCloudDataSourceCollection
RimFracture
RimStatisticsContourMap
RimFlowCharacteristicsPlot
RimWellAllocationOverTimePlot
RimGeoMechCase
RimGeoMechFaultReactivationResult
RimHistogramMultiPlot
RimCustomObjectiveFunctionWeight
RimEclipseStatisticsCase
RimRegularLegendConfig
RimTernaryLegendConfig
RimWellTargetMapping
RimDeltaSummaryEnsemble
RimEnsembleCurveFilter
RimEnsembleCurveFilterCollection
RimEnsembleCurveSet
LineEditAndPushButtons
DemoPdmObject </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Refactoring Guide: PushButtonEditor Fields #590

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.