Update Dockerfile to build ModEM with CMake and change CMake output directory#43
Merged
MiCurry merged 1 commit intomagnetotellurics:mainfrom Mar 5, 2026
Merged
Conversation
…irectory This commit updates the Dockerfile so that it builds each of the ModEM forward formulations using CMake. This will help to test both the configure build chain and the new ModEM build chain. In the Dockerfile, it runs the cmake build in `/home/modem/modem-build`. This commit also updates the CMake ModEM build so that the exectuables no longer are generated in the `$CMAKE_BINARY_DIR/f90/` directory and are instead just in the top level `$CMAKE_BINARY_DIR` directory.
Member
Author
|
Gonna merge this in quickly as I'd like to get #39 in and this change will allow that change to be tested in the github workflow. Since this isn't a code change, this shouldn't disrupt anyone's workflows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the Dockerfile so that it builds each of the ModEM forward formulations using CMake. This will help to test both the configure build chain and the new ModEM build chain.
In the Dockerfile, it runs the cmake build in
/home/modem/modem-build.This commit also updates the CMake ModEM build so that the exectuables no longer are generated in the
$CMAKE_BINARY_DIR/f90/directory and are instead just in the top level$CMAKE_BINARY_DIRdirectory.This pull request also updates the Docker image to allow the
modemuser to use thesudocommand. It installs sudo, adds themodemuser to the sudo group and then disables the need for a password:echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers. This will make it more convenient for users to install libraries and perform other sudo tasks without having to edit and re-build the dockerfile, or logging into the root user.I feel safe including the sudo change in as this is not a production web-server Docker image. Likewise the docker image serves as a sandbox and even before this change users could easily log in to the docker image as the root user. However, docker users should still not use the
--privilegedflag when running the docker image, and they should only mount specific project directories and not their total home directory or their host root system.