Update utils.py for compatibility with Django 1.10 +#5
Open
becky-jisc wants to merge 1 commit intomagopian:masterfrom
Open
Update utils.py for compatibility with Django 1.10 +#5becky-jisc wants to merge 1 commit intomagopian:masterfrom
becky-jisc wants to merge 1 commit intomagopian:masterfrom
Conversation
Updated for compatibility with Django 1.10 + Replaced the get_all_field_names and get_field_by_name methods, which have been removed from the Model._meta API. https://docs.djangoproject.com/en/2.0/ref/models/meta/#migrating-from-the-old-api
Owner
|
Hi, I'm not maintaining this repository anymore. If it's useful to you, please let me know and we can discuss adding you as a maintainer. Regarding the travis failure, it seems that you've used tabs, while the project is using spaces. Also, this will probably need some kind of backwards compatibility. Thanks for your contribution! |
Author
|
Hey Matheiu,
Thanks for letting me know. I’ve overridden that method in my code and so am not too worried about the source being changed. But happy to make the changes if it’ll help others, seeing as I’m half way there!
Becky
From: Mathieu Agopian <notifications@github.com>
Reply-To: magopian/django-inspect-model <reply@reply.github.com>
Date: Friday, March 9, 2018 at 9:51 AM
To: magopian/django-inspect-model <django-inspect-model@noreply.github.com>
Cc: Becky Smith <Becky.Smith@jisc.ac.uk>, Author <author@noreply.github.com>
Subject: Re: [magopian/django-inspect-model] Update utils.py for compatibility with Django 1.10 + (#5)
Hi,
I'm not maintaining this repository anymore. If it's useful to you, please let me know and we can discuss adding you as a maintainer.
Regarding the travis failure, it seems that you've used tabs, while the project is using spaces. Also, this will probably need some kind of backwards compatibility.
Thanks for your contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#5 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AgEaNKnQgrIR_eMZRBIciE5I8Rm06Vscks5tclCFgaJpZM4Si_sS>.
Jisc is a registered charity (number 1149740) and a company limited by guarantee which is registered in England under Company No. 5747339, VAT No. GB 197 0632 86. Jisc’s registered office is: One Castlepark, Tower Hill, Bristol, BS2 0JA. T 0203 697 5800.
Jisc Services Limited is a wholly owned Jisc subsidiary and a company limited by guarantee which is registered in England under company number 2881024, VAT number GB 197 0632 86. The registered office is: One Castle Park, Tower Hill, Bristol BS2 0JA. T 0203 697 5800.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated for compatibility with Django 1.10 +
Replaced the get_all_field_names and get_field_by_name methods, which have been removed from the Model._meta API.
https://docs.djangoproject.com/en/2.0/ref/models/meta/#migrating-from-the-old-api