Skip to content

refactor(storage): generalize move object feature to all types of buckets #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mahendra-google wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(storage): generalize move object feature to all types of buckets #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

using Google.Cloud.ClientTesting;
using System.IO;
using System.Linq;
using System.Net;
using System.Threading.Tasks;
using Xunit;
Expand All @@ -35,7 +34,7 @@ public class MoveObjectTest
public MoveObjectTest(StorageFixture fixture)
{
_fixture = fixture;
_bucket = _fixture.HnsBucket;
_bucket = _fixture.InitiallyEmptyBucket;
Comment thread
mahendra-google marked this conversation as resolved.
_originName = IdGenerator.FromGuid();
_destinationName = IdGenerator.FromGuid();
_contentType = "application/octet-stream";
Expand Down
8 changes: 1 addition & 7 deletions apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public sealed class StorageFixture : CloudProjectFixtureBase, ICollectionFixture

/// <summary>
/// Name of a bucket which already exists, but has no canned data. Mostly used
/// for creating objects.
/// for creating and moving objects.
/// </summary>
public string InitiallyEmptyBucket => BucketPrefix + "-empty";

Expand All @@ -61,11 +61,6 @@ public sealed class StorageFixture : CloudProjectFixtureBase, ICollectionFixture
/// </summary>
public string SoftDeleteBucket => BucketPrefix + "-soft-delete";

/// <summary>
/// Name of a bucket with hierarchical namespace enabled
/// </summary>
public string HnsBucket => BucketPrefix + "-hns";

/// <summary>
/// A small amount of content. Do not mutate the array.
/// </summary>
Expand Down Expand Up @@ -172,7 +167,6 @@ public StorageFixture()
CreateBucket(LabelsTestBucket, multiVersion: false);
CreateBucket(InitiallyEmptyBucket, multiVersion: false);
CreateBucket(SoftDeleteBucket, multiVersion: false, softDelete: true);
CreateBucket(HnsBucket, multiVersion: false, hnsEnabled: true);

RequesterPaysClient = CreateRequesterPaysClient();
if (RequesterPaysClient != null)
Expand Down
4 changes: 2 additions & 2 deletions apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClient.MoveObject.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ namespace Google.Cloud.Storage.V1;
public abstract partial class StorageClient
{
/// <summary>
/// Moves an object within a bucket with hierarchical namespace enabled. This method uses the
/// Moves an object within a bucket. This method uses the
/// <c>moveObject</c> underlying API operation for more flexibility and reliability.
/// </summary>
/// <param name="sourceBucket">Name of the bucket containing the object to move. Must not be null.</param>
Expand All @@ -41,7 +41,7 @@ public virtual Object MoveObject(
}

/// <summary>
/// Moves an object within a bucket with hierarchical namespace enabled. This method uses the
/// Moves an object within a bucket. This method uses the
/// <c>moveObject</c> underlying API operation for more flexibility and reliability.
/// </summary>
/// <param name="sourceBucket">Name of the bucket containing the object to move. Must not be null.</param>
Expand Down
Loading