Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public void ModifyRequest_DefaultOptions()
Assert.Null(request.MaxResults);
Assert.Null(request.PageToken);
Assert.Null(request.SoftDeleted);
Assert.Null(request.ReturnPartialSuccess);
}

[Fact]
Expand All @@ -45,6 +46,7 @@ public void ModifyRequest_AllOptions()
PageToken = "nextpage",
Fields = "items(name),nextPageToken",
SoftDeletedOnly = true,
ReturnPartialSuccess = true
};
options.ModifyRequest(request);
Assert.Equal(10, request.MaxResults);
Expand All @@ -53,6 +55,7 @@ public void ModifyRequest_AllOptions()
Assert.Equal("nextpage", request.PageToken);
Assert.Equal("items(name),nextPageToken", request.Fields);
Assert.True(request.SoftDeleted);
Assert.True(request.ReturnPartialSuccess);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<ItemGroup>
<PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="All" />
<PackageReference Include="Google.Api.Gax.Rest" />
<PackageReference Include="Google.Apis.Storage.v1" VersionOverride="[1.69.0.3707, 2.0.0.0)" />
<PackageReference Include="Google.Apis.Storage.v1" VersionOverride="[1.71.0.3920, 2.0.0.0)" />
</ItemGroup>
<ItemGroup>
<Compile Update="StorageClient.*.cs">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,12 @@ public sealed class ListBucketsOptions
/// </summary>
public bool? SoftDeletedOnly { get; set; }

/// <summary>
/// If true, buckets from reachable locations are returned. The resource names of buckets from unreachable locations will be available on the <c>Unreachable</c>
/// property of a raw response from <see cref="PagedEnumerable{TResponse, TResource}.AsRawResponses"/>. The default is false.
/// </summary>
Comment thread
mahendra-google marked this conversation as resolved.
public bool? ReturnPartialSuccess { get; set; }

/// <summary>
/// Modifies the specified request for all non-null properties of this options object.
/// </summary>
Expand Down Expand Up @@ -97,6 +103,10 @@ internal void ModifyRequest(ListRequest request)
{
request.SoftDeleted = SoftDeletedOnly;
}
if (ReturnPartialSuccess != null)
{
request.ReturnPartialSuccess = ReturnPartialSuccess;
}
}
}
}
4 changes: 2 additions & 2 deletions generator-input/apis.json
Original file line number Diff line number Diff line change
Expand Up @@ -5599,7 +5599,7 @@
"description": "Recommended Google client library to access the Google Cloud Storage API. It wraps the Google.Apis.Storage.v1 client library, making common operations simpler in client code. Google Cloud Storage stores and retrieves potentially large, immutable data objects.",
"dependencies": {
"Google.Api.Gax.Rest": "default",
"Google.Apis.Storage.v1": "1.69.0.3707"
"Google.Apis.Storage.v1": "1.71.0.3920"
},
"testDependencies": {
"Google.Api.Gax.Testing": "default",
Expand Down Expand Up @@ -7420,4 +7420,4 @@
]
}
]
}
}
Loading