Open
Conversation
mainframev
force-pushed
the
chore/migrate-to-yarn-modern
branch
4 times, most recently
from
9520bde to
aeffb77
Compare
mainframev
force-pushed
the
chore/migrate-to-yarn-modern
branch
from
aeffb77 to
46e89a2
Compare
eslint-plugin-import@2.32.0 now includes the import plugin in flatConfigs.typescript, causing a duplicate plugin error when the plugin was also explicitly registered in the plugins object.
- web-components: use 'rollup' directly instead of 'yarn rollup' which in Yarn Modern looks for a script named 'rollup' rather than the binary - react-tabster: add required 'diagnostics' property and fix 'cancel' return type to match tabster@8.7.0 interface changes
- Add explicit return type annotations to webpackFinal/webpack functions to avoid
TypeScript inferring types from nested webpack packages
- Cast config to import('webpack').Configuration to fix type mismatch
- Add empty types array to chart-web-components tsconfig.lib.json to prevent
auto-discovery of deprecated @types/chokidar
- Fix yarn rollup command in chart-web-components (same issue as web-components)
Use ^8.46.2 instead of pinned 8.46.2 to allow resolution to the same version as @typescript-eslint/utils (8.54.0), fixing type mismatch in eslint-plugin-react-components tests.
API Extractor generated a slightly different key order in Record type signature (cosmetic change, no functional impact).
The import plugin is already registered by importPlugin.flatConfigs.typescript in core.js (eslint-plugin-import@2.32.0+). Registering it again in imports.js causes 'Cannot redefine plugin import' error when both configs are used.
Yarn Modern returns dependencies in a different order than Yarn Classic. The test snapshot is updated to reflect this ordering change.
mainframev
force-pushed
the
chore/migrate-to-yarn-modern
branch
from
5e25404 to
8a0fb68
Compare
…y with Yarn Modern
… to fix ESM/CJS compatibility
…pshots for Yarn Modern
…flicts in Yarn Modern
…flicts in Yarn Modern
… conflicts in Yarn Modern
The SankeyChart component handles node selection via onMouseOver, not onClick. The test was incorrectly using fireEvent.click which worked inconsistently across environments. Changed to fireEvent.mouseOver to match the actual component behavior and fixed the test description.
…dern compatibility The -B (binaries-only) flag in Yarn Modern skips user-defined scripts and only looks for binaries. This caused issues with tools like test-ssr that need a wrapper script in root package.json to work correctly. Changes: - Change exec from 'yarn run -TB' to 'yarn run -T' - Add test-ssr script to root package.json as a proxy to the binary
…odern Projects with custom test-ssr targets need to use 'yarn run -T test-ssr' instead of 'yarn test-ssr' for Yarn Modern compatibility. Fixed projects: - react-charts-stories - react-dialog-stories - react-drawer-stories - react-positioning-stories
… interaction in SankeyChart test
- Remove @ts-check from vr-tests-react-components storybook config to avoid webpack type conflicts - Disable checkJs in vr-tests-react-components tsconfig - Create package.json in temp dirs for integration tests (Yarn Modern requires it)
- Add package.json to util directory in prepareCreateReactApp for Yarn Modern - Use 'yarn run -T tsc' instead of 'yarn tsc' in ts-minbar integration tests
…eyChart test The test was flaky because screen.getAllByText was not reliably finding rect elements. Using container.querySelectorAll is more reliable and the extended timeout (5s) gives enough time for the sankey layout computation to complete.
…only error create-react-app tries to write a deprecation warning file inside its package, which fails with Yarn PnP since packages are stored in read-only zip files. Configure the temp utility project to use node-modules linker instead.
- Add explicit compilerOptions in ts-node register to force CommonJS module resolution (fixes TSError TS5109 with NodeNext module inference) - Increase generateEntryPoints test timeout to 15s for slower CI environments
In CI environments (especially Linux), Chrome requires --no-sandbox and --disable-setuid-sandbox flags to run properly. This fixes the 'No usable sandbox' error that occurs when running Puppeteer tests in GitHub Actions. See: https://github.com/puppeteer/puppeteer/blob/main/docs/troubleshooting.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testing yarn modern