Skip to content

Update linter setup#1017

Open
pichfl wants to merge 9 commits intomainfrom
pichfl/update-linters
Open

Update linter setup#1017
pichfl wants to merge 9 commits intomainfrom
pichfl/update-linters

Conversation

@pichfl
Copy link
Copy Markdown
Contributor

@pichfl pichfl commented Jul 12, 2025

  • ESLint 9
  • latest Prettier
  • move import sorting from eslint to prettier (as recommended by the author of the eslint plugin we used before)
  • cleanup files
  • deduplicate configuration

@pichfl pichfl requested review from Copilot and mansona July 12, 2025 18:15
@pichfl pichfl mentioned this pull request Jul 12, 2025
1 task
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the linter setup across the project by migrating from ESLint 8 to ESLint 9, updating to the latest Prettier version, and reorganizing import sorting from ESLint to Prettier. The changes also include configuration deduplication and file cleanup to modernize the development tooling.

  • Upgrade ESLint from v8 to v9 with new flat configuration format
  • Update Prettier to v3.6.2 and move import sorting from ESLint to Prettier plugins
  • Consolidate configuration files and remove duplicated linting rules

Reviewed Changes

Copilot reviewed 46 out of 48 changed files in this pull request and generated 4 comments.

File Description
packages/*/eslint.config.mjs New ESLint v9 flat configuration replacing legacy .eslintrc.js files
packages/*/.prettierrc.cjs Consolidated Prettier configuration inheriting from root config
packages/*/package.json Updated dependencies and build scripts for new linting setup
Various JS/HTML/CSS files Reformatted code according to new Prettier configuration

Comment on lines +10 to +16
{{content-for "head"}} {{content-for "test-head"}}

<link rel="stylesheet" href="{{rootURL}}assets/vendor.css">
<link rel="stylesheet" href="{{rootURL}}assets/test-app.css">
<link rel="stylesheet" href="{{rootURL}}assets/test-support.css">
<link rel="stylesheet" href="{{rootURL}}assets/vendor.css" />
<link rel="stylesheet" href="{{rootURL}}assets/test-app.css" />
<link rel="stylesheet" href="{{rootURL}}assets/test-support.css" />

{{content-for "head-footer"}}
{{content-for "test-head-footer"}}
{{content-for "head-footer"}} {{content-for "test-head-footer"}}
Copy link

Copilot AI Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Combining multiple Handlebars expressions on a single line reduces readability. Consider keeping these on separate lines for better maintainability.

Copilot uses AI. Check for mistakes.

{{content-for "head-footer"}}
{{content-for "test-head-footer"}}
{{content-for "head-footer"}} {{content-for "test-head-footer"}}
Copy link

Copilot AI Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Combining multiple Handlebars expressions on a single line reduces readability. Consider keeping these on separate lines for better maintainability.

Suggested change
{{content-for "head-footer"}} {{content-for "test-head-footer"}}
{{content-for "head-footer"}}
{{content-for "test-head-footer"}}

Copilot uses AI. Check for mistakes.
<body>
{{content-for "body"}}
{{content-for "test-body"}}
{{content-for "body"}} {{content-for "test-body"}}
Copy link

Copilot AI Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Combining multiple Handlebars expressions on a single line reduces readability. Consider keeping these on separate lines for better maintainability.

Suggested change
{{content-for "body"}} {{content-for "test-body"}}
{{content-for "body"}}
{{content-for "test-body"}}

Copilot uses AI. Check for mistakes.

{{content-for "body-footer"}}
{{content-for "test-body-footer"}}
{{content-for "body-footer"}} {{content-for "test-body-footer"}}
Copy link

Copilot AI Jul 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Combining multiple Handlebars expressions on a single line reduces readability. Consider keeping these on separate lines for better maintainability.

Suggested change
{{content-for "body-footer"}} {{content-for "test-body-footer"}}
{{content-for "body-footer"}}
{{content-for "test-body-footer"}}

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants