Fix Rails 8.1+ compatibility replacing Benchmark with Process.clock_gettime#43
Closed
joshRpowell wants to merge 1 commit intomakandra:masterfrom
Closed
Fix Rails 8.1+ compatibility replacing Benchmark with Process.clock_gettime#43joshRpowell wants to merge 1 commit intomakandra:masterfrom
joshRpowell wants to merge 1 commit intomakandra:masterfrom
Conversation
Contributor
|
Hi @joshRpowell, thanks for figuring out. I extracted your change to a module |
Contributor
|
Version 0.7.3 is released now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ruby 3.4+, the Benchmark constant is no longer reliably available
in gem contexts when loaded through Rails 8.1, causing
NameError: uninitialized constant Benchmark.This replaces
Benchmark.realtimewithProcess.clock_gettime, which:Fixes compatibility with:
No behavior changes - Process.clock_gettime(Process::CLOCK_MONOTONIC)
is actually what Benchmark.realtime uses internally.