Open
Conversation
soullivaneuh
force-pushed
the
sticky-channel
branch
from
dc68506 to
909468d
Compare
soullivaneuh
force-pushed
the
sticky-channel
branch
from
909468d to
2066ab4
Compare
Author
|
Added a note on readme. |
With this option, all message will be sent to the default channel only. This is useful for dev environment when you want to concentrate all test message to a specific test channel.
soullivaneuh
force-pushed
the
sticky-channel
branch
from
2066ab4 to
6a311ec
Compare
|
Fabiencdp
approved these changes
Nov 16, 2016
Gummibeer
suggested changes
Nov 16, 2016
Gummibeer
left a comment
Gummibeer
left a comment
There was a problem hiding this comment.
Except the single boolean cast everything is ok.
| * @return bool | ||
| */ | ||
| public function isStickyChannel() | ||
| { |
There was a problem hiding this comment.
This will force the result to be an boolean. Otherwise it can also be any other type.
return (bool) $this->sticky_channel;
Author
There was a problem hiding this comment.
According to the phpdoc, sticky_channel must be a boolean and developpers should respect this.
Casting anything to a boolean is not the right way IMO.
When this project will use PHP >=7.0, then we will be able to use strict type instead.
smety
approved these changes
Jul 15, 2017
Author
|
Any news about this MR? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40
With this option, all message will be sent to the default channel only.
This is useful for dev environment when you want to concentrate all test message to a specific test channel.
This was dicussed for a long time on #40 but we finally get an agreement with @Gummibeer at #40 (comment) 😉
@maknz Could you please review the code and merge it if it looks OK? Thanks.