Conversation
* README.md: Add installation guide for Mac OSX, and use TexMobject for equations in the LaTeX tutorial (It's spelled as `LaTeX` instead of `LaTex`). See more in README.md
* README.md: Add one space after each `#`
* README.md: Do not show links directly
| @@ -1,11 +1,11 @@ | |||
| # Manim-Tutorial | |||
| A tutorial for manim, a mathematical animation engine made by 3b1b for Python. | |||
| ## Requirements | |||
There was a problem hiding this comment.
You don't have to entirely remove the req section. This guide is for everyone, including beginners. In the past, there have been beginners that have used this. So, leave the req section with Python as one of the reqs, and change linux to mac, linux or window.
There was a problem hiding this comment.
Keep Original. I will change it
README.md
Outdated
There was a problem hiding this comment.
Good Job with the Mac addition.
| For subscripts, it is similar. | ||
|
|
||
| ```python | ||
| subScript_equation = TextMobject("$\\theta_{1}$") |
There was a problem hiding this comment.
The $ signify an equation. Even if it isn't required its good practice. It should be left there.
malhotra5
left a comment
malhotra5
left a comment
There was a problem hiding this comment.
For the long term, I think these are good changes. Thanks for the insights.
README.md
Outdated
There was a problem hiding this comment.
Test that this works. As far as I know, this doesn't work yet on Linux or Windows.
There was a problem hiding this comment.
Keep original. Only add mac additions
README.md
Outdated
README.md
Outdated
| $ pip3 install pycairo | ||
| ``` | ||
|
|
||
| * Problem #2: **Exception: Latex error converting to dvi. See log output above or the log file** |
There was a problem hiding this comment.
Keep original. I will take all your syntax changes into account, and give you credit for it.
README.md
Outdated
| ``` | ||
|
|
||
| We will break this into parts: | ||
| * Import: The import in this code is the import we will use in all manim projects. It has almost all the imports we will ever require |
README.md
Outdated
README.md
Outdated
| * FadeOut | ||
| * GrowFromCenter | ||
|
|
||
| **Adding:** |
| * Add | ||
|
|
||
| In this code, I specifically included an example that I found useful to know. | ||
| ``` python |
There was a problem hiding this comment.
This was changed in another commit. That has been taken into account. Ignore this.
README.md
Outdated
There was a problem hiding this comment.
These header addition are good. Keep them.
README.md
Outdated
README.md
Outdated
README.md
Outdated
malhotra5
left a comment
malhotra5
left a comment
There was a problem hiding this comment.
I don't think I will approve this yet. There are parts where you are knit picking my style of writing. I understand that there are problems with it as I wrote it in a rush, but I want to fix that myself. So, leave that to me and just keep the Mac installation. My comments will specify whether to keep original versions of the README or update it with your version.
malhotra5
left a comment
malhotra5
left a comment
There was a problem hiding this comment.
I don't think I will approve this yet. There are parts where you are knit picking my style of writing. I understand that there are problems with it as I wrote it in a rush, but I want to fix that myself. So, leave that to me and just keep the Mac installation. My comments will specify whether to keep original versions of the README or update it with your version.
| @@ -123,13 +123,13 @@ from manimlib.imports import * | |||
|
|
|||
There was a problem hiding this comment.
Everything looks good. Keep changes
| @@ -571,10 +571,8 @@ Manim is extremely powerful, and is capable of creating high quality graphics. Y | |||
|
|
|||
There was a problem hiding this comment.
Everything looks good. Keep changes.
|
I am so sorry that I really did not have enough time to read and change
README according to your review. I wonder if I can revert everything but
only adding the Mac installation part. Or could I just delete my own fork
because the changing these content get _extremely_ hard since I put all of
them in **one** commit. I also plan to quit the task of editing README
since I have more ideas on the Reverse Engineering of Manim.
Best Wishes,
Travor Liu
…On Sat, 13 Jul 2019, Rohit Malhotra wrote:
@malhotra5 requested changes on this pull request.
I don't think I will approve this yet. There are parts where you are knit
picking my style of writing. I understand that there are problems with it as
I wrote it in a rush, but I want to fix that myself. So, leave that to me
and just keep the Mac installation. My comments will specify whether to keep
original versions of the README or update it with your version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute thethread.[AF5X74IFUOXEIFTK5DR2A23P7JE4FA5CNFSM4IC2ITDKYY3PNVWWK3TUL52HS4DFWFI
HK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6LQ45Y.gif]
|
2 participants
I put more details on the installation guide and tutorial, and I make corrections about formulas. More details can be found in the diff of the commits