Skip to content

Don't rely on object, it's not always set#444

Merged
malthe merged 4 commits intomasterfrom
issue-443-unicode-decode-error
Mar 12, 2026
Merged

Don't rely on object, it's not always set#444
malthe merged 4 commits intomasterfrom
issue-443-unicode-decode-error

Conversation

@malthe
Copy link
Copy Markdown
Owner

@malthe malthe commented Mar 11, 2026

This fixes issue #443.

@malthe
Copy link
Copy Markdown
Owner Author

malthe commented Mar 11, 2026

@vnmabus this is pretty old code and I honestly don't recall exactly where things are how they are, but I think accessing exc.args[1] here instead of exc.object is safe (and does the trick).

@malthe malthe force-pushed the issue-443-unicode-decode-error branch from 4a8d417 to e9d2b43 Compare March 11, 2026 15:42
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 11, 2026

Pull Request Test Coverage Report for Build 22994023202

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 92.38%

Totals Coverage Status
Change from base Build 13355029106: 0.02%
Covered Lines: 3933
Relevant Lines: 4183

💛 - Coveralls

@malthe malthe merged commit 90b9002 into master Mar 12, 2026
29 checks passed
@malthe malthe deleted the issue-443-unicode-decode-error branch March 12, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants