Skip to content

bugfixes && small improvements, opens browser by default #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

JohannesHoppe
Copy link

... just npm start now!

Bugfixes for your article:

Your article mentions also npm run ngc:server but it should be npm run start:server.
There was a big error in npm server. Wrong file name and you have to cd into the folder, so that . resolves correctly. In the article you mention this, but you forget to update the run script.

Some friendly hints regarding your code:

  1. you are completely ignoring your .editorconfig
  2. go for tslint, a lot of https://palantir.github.io/tslint/rules/prefer-const/ and https://palantir.github.io/tslint/rules/no-inferrable-types/ everywhere
  3. you are also violating the style guide. a lot of https://goo.gl/cix8BY in your code
    see tslint.json > "directive-selector" / "component-selector"

Anyway, thanks for the post and this sample repo. This is a great help to get started.

@JohannesHoppe
Copy link
Author

@manfredsteyer Ey, ignorieren gilt nicht! 😉

@AndrewKralovec
Copy link

I cloned your branch and ran npm install & then npm start. I got the following error him my console.

ERROR in Error encountered resolving symbol values statically. Could not resolve @angular/animations/browser relative to D:/Workspace/node/kittens/angular-ssr/node_mo
dules/@angular/platform-browser/animations/index.d.ts., resolving symbol ɵe in D:/Workspace/node/kittens/angular-ssr/node_modules/@angular/platform-browser/animations
/index.d.ts, resolving symbol BrowserAnimationsModule in D:/Workspace/node/kittens/angular-ssr/node_modules/@angular/platform-browser/animations/index.d.ts, resolving
 symbol BrowserAnimationsModule in D:/Workspace/node/kittens/angular-ssr/node_modules/@angular/platform-browser/animations/index.d.ts

ERROR in ./src/main.ts
Module not found: Error: Can't resolve './../$$_gendir/src/app/app.module.ngfactory' in 'D:\Workspace\node\kittens\angular-ssr\src'
 @ ./src/main.ts 4:0-81
 @ multi ./src/main.ts

@mikezks
Copy link

mikezks commented Jul 25, 2017

@AndrewKralovec
Run "node_modules/.bin/ngc" -p tsconfig.server.json before you build with npm run build:all.
See the Angular AOT documentation for details on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants