Skip to content

feat: rewrite random.cpp#44

Merged
manoflearning merged 1 commit intomainfrom
random
Jan 3, 2026
Merged

feat: rewrite random.cpp#44
manoflearning merged 1 commit intomainfrom
random

Conversation

@manoflearning
Copy link
Owner

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 158eaa98d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +3 to +5
// what: mt19937_64 quick usage snippet (time-seeded + rand range + shuffle).
// time: O(1) per draw; memory: O(1)
// constraint: uniform_int_distribution is inclusive [l, r].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep a usable RNG helper in random.cpp

This file now contains only comments and no implementation, so including src/8-misc/random.cpp no longer defines the previously available rng helper. Any existing templates that relied on rng (as provided before this commit) will now fail to compile after updating, which is a breaking change for the library. If the intent is to keep a quick RNG utility, the module needs to still export a minimal wrapper or type alias instead of being comment-only.

Useful? React with 👍 / 👎.

@manoflearning manoflearning merged commit 4c3a5cd into main Jan 3, 2026
2 checks passed
@manoflearning manoflearning deleted the random branch January 3, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant