-
Notifications
You must be signed in to change notification settings - Fork 130
Add prek GitHub Action #40339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add prek GitHub Action #40339
Conversation
This action installs prek and runs `prek run --all-files` on the repository.
Removed space between elements in the return statement of getSpherical method.
jhaigh0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Are we going to replace this locally somehow too?
|
Yeah I'd suggest swapping out @thomashampson what do you think? |
|
I think this is probably one for the next TWG.... @peterfpeterson ? |
|
Where the current pre-commit PR job configured? |
|
@thomashampson got to https://pre-commit.ci/, login, and enable/disable the repository. Otherwise, the configuration itself is at the top of $ head ~/code/mantid/.pre-commit-config.yaml
default_language_version:
python: python3
exclude: ^$|instrument/
ci:
autofix_prs: true |
This adds a workflow to run
prekon a PR.prekis a Rust version ofpre-commit, see here.It will run all the hooks in the existing
.pre-commit-config.yamlfile.If it has produced fixes, then those are committed to the PR branch.
Once this is in we can delete the
pre-commitjob.To test:
This is a PR on my fork where you can see me making a formatting change and
prekfixing it, jclarkeSTFC#2Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
mantid-developersormantid-contributorsteams, add a review commentrerun cito authorize/rerun the CIGatekeeper
As per the gatekeeping guidelines: