Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Makefile target for running all download scripts together and updates the Selenium configuration in the
data_acquisition_scrape.pyscript to streamline the scraping process. Below are the most important changes grouped by theme:New Makefile Target:
run_all_downloadtarget in theMakefileto execute multiple download scripts (run_glide_download,run_cerf_download,run_disaster_charter_download, andrun_idus_download) in a single command. This simplifies running all downloads at once.Selenium Configuration Updates:
GECKODRIVER_PATHinsrc/glide/data_acquisition_scrape.pyto point to/usr/local/bin/geckodriverfor better compatibility.PROFILE_PATHpointing to a Linux-based Firefox profile, replacing the macOS-specific path, to improve cross-platform functionality.-profileargument with thePROFILE_PATHin thescrape_with_seleniumfunction to ensure the correct Firefox profile is used during scraping.