Skip to content

Conversation

JulienRAVIA
Copy link
Contributor

@JulienRAVIA JulienRAVIA commented Jan 8, 2024

@JulienRAVIA JulienRAVIA requested a review from jdeniau January 8, 2024 15:21
string $path,
array $params = [],
int $code = 0,
?Exception $previous = null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bof, d'enlever ce ?, c'est bien nullable (la valeur par défaut est d'ailleurs null)
C'est prettier qui fait ça ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oui c'est prettier

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK ça doit être la PER1 peut-être. Si ce n'est pas le cas il le remettra tout seul

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est quoi la PER1 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.php-fig.org/per/coding-style/

Per coding style pardon : per = standard évolutif, remplace les PSR2 ET 12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants