This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Support Layout and Format nodes in text and shield symbolizers#358
Open
hollinger wants to merge 3 commits intomapbox:masterfrom
Open
Support Layout and Format nodes in text and shield symbolizers#358hollinger wants to merge 3 commits intomapbox:masterfrom
hollinger wants to merge 3 commits intomapbox:masterfrom
Conversation
This update reads information about symbolizer child elements from mapnik-reference. This information is used to create child elements in the XML, based on psuedo element syntax parsed from mss. Rendering of tags for symbolizers and child elements is similar, so the rendering is handled by a new shared object called RenderNode. This also handles indentation for nested child nodes.
Three primary test focuses: 1. Rendering nested pseudo elements and properly handling indentation 2. Ordering of the child elements in the symbolizer, based on order from mapnik-reference and indexes from mss syntax 3. Handling override and inheritance of child elements and their attributes from rule to rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a potential update for review. The goal to support definition of layout and format nodes in carto, as discussed in #347. Pseudo-element sytax is used to create child elements within the symbolizers. Test cases are included, which demonstrate the syntax and resulting xml.
Note that this also requires a change in mapnik-reference: mapnik/mapnik-reference#62.