Skip to content

LineBucket: skip two vertex segments except end, fix #1271 #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devemux86 merged 1 commit into from
Dec 18, 2025
Merged

LineBucket: skip two vertex segments except end, fix #1271 #1272

devemux86 merged 1 commit into from
Dec 18, 2025

Conversation

@devemux86
Copy link
Collaborator

@devemux86 devemux86 commented Dec 16, 2025 •
edited
Loading

This was referenced Dec 16, 2025
Closed
Closed
eddiemuc
eddiemuc approved these changes Dec 17, 2025
View reviewed changes
Copy link

@eddiemuc eddiemuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is rather complex, seems that situation can only occur when closed is true.

Fix LGTM

@devemux86
Copy link
Collaborator Author

devemux86 commented Dec 17, 2025

@eddiemuc OpenGL is complex. 🙂

@devemux86 devemux86 added the bug label Dec 18, 2025
@devemux86 devemux86 added this to the 0.27.0 milestone Dec 18, 2025
@devemux86 devemux86 merged commit 367654e into master Dec 18, 2025
1 check passed
@devemux86 devemux86 deleted the mindist branch December 18, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eddiemuc eddiemuc eddiemuc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

3 participants

@devemux86 @eddiemuc