Open
Conversation
|
After you install .eslintrc, if you install 'eslint plugin' in your vscode, you can see some warning or errors when you open 'reviewActions.js' tilde line means warning (green), error (red) For example, according to your eslint rule, disallow call 'console' object. so, you can set
const Console = console;
...
Console.log(...)or you can
"rules": {
"react/jsx-filename-extension": [
1,
{
"extensions": [".js", ".jsx"]
}
],
"react/prop-types": 0,
"no-underscore-dangle": 0,
"import/imports-first": ["error", "absolute-first"],
"import/newline-after-import": "error",
"no-console": "off"
},As the same way, red tilde line shows 'currentReviews' was used before it was defined. Then, you can see all warnings are disappears in your file.
That let all developers follow the same rule is the purpose of using Eslint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


fixes #25
Added ESLint for formatting check.
I followed this example:
https://medium.com/quick-code/how-to-integrate-eslint-prettier-in-react-6efbd206d5c4
1- After this is merge npm install is required since there were new package installed in order to rum the application
2- @tangoslee Is there anyway I can test if it is working properly?