Improve usability#118
Open
alanorth wants to merge 3 commits intomarbl:masterfrom
alanorth:improve-usability
Open
Improve usability#118alanorth wants to merge 3 commits intomarbl:masterfrom alanorth:improve-usability
alanorth wants to merge 3 commits intomarbl:masterfrom
alanorth:improve-usability
Conversation
Having them with +x makes the shell autocomplete them when the dir is in the user's $PATH, which is an unnecessary nuissance.
This allows the shell to autocomplete the name of the script like any other executable when the SALSA dir is in the user's $PATH.
These scripts are already executable due to their chmod +x, but they are missing a shebang to tell the shell which interpreter is respons- ible for executing them. The convention is to use the "env" command to find an appropriate Python that may be in the user's environment instead of hard coding a path, as the user might have a virtual env loaded or might have Python 3 as the default "python" on the system.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor usability improvements:
run_pipeline.pypython2 blah.py(they already have an executable bit). Note that you can still run them withpython2manually if you want.These changes improve the usability when installed system-wide in a multi-user cluster with many versions of Python available, etc.