Close some prs and fix bugs #341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If run as windows service, use cliOptions = { detached:true} to avoid error: SetProcessDpiAwareness failed: "COM error 0x80070005 (Unknown error 0x0ffffffff80070005)"
Added an option to the generation script to dictate on which page the page numbering should start. Option name is paginationStartPage and is 1 based (to start pagination at page 2, the value would be 2)
Added an option to allow waiting for the page to say when it's finished rendering. if options.onTitleDone is set to true, the page will not take the screenshot until the title is set to "done" on the page. Signed-off-by: Alex Bor <alexhbor@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Closes #141, #334, Properly parse stdout and only exit when json is returned
Closes #203, #281, Change exit behavior, this speeds up the execution and kills the process in the background
Closes #295, Adds
childProcessOptionsoption where you can pass childProcess options to a script (apparently this is used on windows)Features
Closes #173, #260, #264, Add support for window.callPhantom to trigger a render
Closes #259, Adds
httpCookiesoptionCloses #258, Adds
paginationOffsetoption