Awesome tutorial! Thought I'd contribute :) #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… One that sets up the URL, the next that makes the actual request and the third that serializes the JSON :)
… was being called in the serializeAndParseJSON method so I sent it back down the call stack using closures, to make sure that each function was only concerned with its specific task
… are gonna just send back the empty array and do the displayErrorAlert call in searchForArtists in order to keep the code more modular
… a another method that starts the audio session. Small change but keeps the functions more focused
… viewController Class
…vements to be show when they appear. Dont really know what it means, but I presume my Apple overlords know whats best :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Marc, thanks for the tutorial on speech recognition! I liked it a lot so I thought I'd contribute and do some refactoring. I separated the search function into 3 separate ones and moved two (the network request and the serializer) into an APIManager class. I also separated the "startListening" function into 2 functions and added a folder with screenshots of the app so people can take a look at it. Hopefully its a bit more modular and readable.
Thanks again man! :)
-Bereket Ghebremedhin