fix issue of list hiding behind audio player in mobile view#3
fix issue of list hiding behind audio player in mobile view#3ericconner5 wants to merge 1 commit intomarciaga:masterfrom
Conversation
|
@ericconner5 There's some history here. This app was really only intended for internal use; to solve a problem where there was no way to get show archive files via the web. As development for us has always been essentially the endeavor of one person with limited bandwidth, an obvious place to cut development time was in not making the app responsive. Since it was never designed to be responsive, this ticket should have been: make the app responsive. And to be fair, that should be a discussion itself: whether it's valuable to have an internal app that's essentially for DJs to preview and download their shows, needs to be responsive in the first place. Rather than merge in another hard-coded value that may not fix the problem in enough mobile browsers (which we can't test anyway) to be useful, why don't we open this for discussion at the next committee meeting. |
|
@ericconner5 Here's a link to the UI library I used in case you want to scope out what it would take to make the app responsive for mobile devices. https://react-md.mlaursen.com/components/grids |
|
Ah, that makes sense to me. Was good to at least get it set up and have a
go at it.
Thanks!
…On Mon, Jul 15, 2019 at 9:18 PM Mark Arciaga ***@***.***> wrote:
@ericconner5 <https://github.com/ericconner5> Here's a link to the UI
library I used in case you want to scope out what it would take to make the
app responsive for mobile devices.
https://react-md.mlaursen.com/components/grids
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AJ73NZPCXW36RXBB4M3JN7LP7VD25A5CNFSM4ICXMIK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7UTRY#issuecomment-511658439>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ73NZJDFJX3KKIIYLG2DYTP7VD25ANCNFSM4ICXMIKQ>
.
|
|
@ericconner5 No, thank you! Hopefully see you at the next meeting to chat!
|
|
Yes, I'll see ya there, hopefully!
I should have reached out, indeed. At least I got the dev environment up
and all that. That was 99% of the time/effort, so worthwhile for me, still.
On Mon, Jul 15, 2019 at 9:31 PM Mark Arciaga <notifications@github.com>
wrote:
… @ericconner5 <https://github.com/ericconner5> No, thank you! Hopefully
see you at the next meeting to chat!
It's probably a good idea going forward to check in with me before
grabbing any tickets - I can provide a lot of insight and guidance!
Ah, that makes sense to me. Was good to at least get it set up and have a
go at it. Thanks!
… <#m_8072455759678550726_>
On Mon, Jul 15, 2019 at 9:18 PM Mark Arciaga *@*.***> wrote: @ericconner5
<https://github.com/ericconner5> https://github.com/ericconner5 Here's a
link to the UI library I used in case you want to scope out what it would
take to make the app responsive for mobile devices.
https://react-md.mlaursen.com/components/grids — You are receiving this
because you were mentioned. Reply to this email directly, view it on GitHub
<#3 <#3>
?email_source=notifications&email_token=AJ73NZPCXW36RXBB4M3JN7LP7VD25A5CNFSM4ICXMIK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7UTRY#is
suecomment-511658439>, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ73NZJDFJX3KKIIYLG2DYTP7VD25ANCNFSM4ICXMIKQ
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AJ73NZM6X5D5R5F76XL6ZKDP7VFKBA5CNFSM4ICXMIK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ7VEJI#issuecomment-511660581>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJ73NZJW2DBGO7US7KE727DP7VFKBANCNFSM4ICXMIKQ>
.
|
2 participants
https://tree.taiga.io/project/marciaga-kffp-apps/us/100?kanban-status=1030171
this is to fix the issue where the schedule items hide behind the audio player in mobile view.
screenshot of issue from production: https://drive.google.com/open?id=1AByEVS-NXL18od0BH9TcJRP3YU5WwlWa
height of audio player is 86px in chrome on mac.