Code 1: moving to _internal and setting the interface (still broken)#10
Merged
marcinmiklitz merged 8 commits intomarcinmiklitz:developmentfrom Jun 7, 2025
Merged
Conversation
Owner
|
Hey @andrewtarzia, is removing the documentation files on purpose here? I think all these _autosummary files were just introduced in #9. |
Collaborator
Author
|
Yes it is, they aren't correct and don't work without changes in the actual code (this pr just does the interface). So I deleted them. Sorry for the spam. |
marcinmiklitz
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it says in title, this is about checking the interface, which I will then implement the internals of (doing so now would have changes within files hard to tell as files also moved).
The interface is defined in
src/pywindow/__init__.py. Only some functions/classes are accessible, the rest is backend. And they should all just be accessible aspywindow.XX, no sub modules. If you are ok with this, we move to implementation.