Fix memory leaks in search query and response lifecycle#33
Merged
Conversation
- Extract scroll_id before the loop in scroll_hits to ensure ES scroll contexts are always cleared, even if yield raises on the first iteration - Break Response → Query circular reference by storing query_definition instead of the full Query object, allowing GC to collect responses - Make Query#reset! public so apps can clear cached responses - Use lightweight query_definition in event payloads instead of retaining the full Query object reference
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scroll_idfrom the initial response before entering the loop inscroll_hits, ensuring ES scroll contexts are always cleared even if the yield block raises on the first iterationResponsenow storesquery_definition(a Hash) instead of the fullQueryobject, allowing the GC to collect responses and their associated raw response hashes independentlyQuery#reset!public: Apps can now explicitly clear cached@responseon reused Query objects to release memoryquery_definitioninstead of the fullQueryobject reference, preventing accidental retention via subscriber payloads