BOA test with all the features requested#6
Open
pratikbhatia199 wants to merge 12 commits intomarcus-burton:masterfrom
Open
BOA test with all the features requested#6pratikbhatia199 wants to merge 12 commits intomarcus-burton:masterfrom
pratikbhatia199 wants to merge 12 commits intomarcus-burton:masterfrom
Conversation
added 11 commits
May 4, 2016 16:05
…t other logic becomes faster
…gic becomes faster Add change to account for function open Account Added error statement for wrong account created
Remove the account statement not required Added test cases for all accounts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested changes
Additional changes:
Note: Could've added test cases for account but I don't know Nose really well.
Update: I added the test cases after a break to think clearly, took only half hour.
Thanks for giving me the opportunity to interview, this was a really fun activity, I hope to hear from you soon!