Draft
Conversation
* leave as nieve 'localtime' dates for dumbell plot
Owner
|
Thank you @wiredfool - this looks good to me (adds support for Cyclemeter db files). I've not used Cyclemeter before, so I don't have any files to test. @hugovk are you happy with the changes or do you have any thoughts? Please feel free to merge if you are happy. |
Collaborator
|
Hi Eric! I'm fine with the changes (once the linter is appeased), it would be nice to add a test database to make sure the code runs properly. Can we create one with the GPX files in https://github.com/marcusvolz/strava_py/tree/main/tests/gpx? We don't have unit tests (yet?) but there's some sanity test runs in Linter: $ pip install pre-commit; pre-commit run --all-files
$ # or
$ pip install black isort flake8; black .; isort .; flake8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cyclemeter stores similar data to Strava -- at least, you can download a sqlite db of all the activity data stored in your personal iCloud instance.
This is a draft PR to provide basic support to pull data from that sqlitedb and run the same visualizations as from Strava. Not sure if this makes sense as an addition to this project or a fork. Your call on that one.
Some caveats: