Fix regex parse to actually match pure IPv4 or IPv6 with optional netmask#7
Open
pjbakker wants to merge 2 commits intomariodpros:masterfrom
pjbakker:master
Open
Fix regex parse to actually match pure IPv4 or IPv6 with optional netmask#7pjbakker wants to merge 2 commits intomariodpros:masterfrom pjbakker:master
pjbakker wants to merge 2 commits intomariodpros:masterfrom
pjbakker:master
Conversation
If they contain : (i.e. IPv6 address) SLS cannot be parsed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current match and return didn't actually match any real values and returned nothing, which resulted in an invalid cmd.
Split the matcher into one for IPv4 (with optional netmask) and one for IPv6 (with optional netmask). And fixed the return value.
Now you can actually add IPv6 to your pillar and it works.