Potential fix for code scanning alert no. 504: Workflow does not contain permissions#62
Merged
Potential fix for code scanning alert no. 504: Workflow does not contain permissions#62
Conversation
…ain permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Mario Hernandez <mariofix@proton.me>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mariofix/pyflowcl/security/code-scanning/504
In general, the fix is to explicitly restrict the
GITHUB_TOKENpermissions in the workflow by adding apermissions:block, either at the root (applying to all jobs) or within thetestsjob. Since this workflow only checks out code, runs tests, uploads coverage to external services, and uploads an artifact, it only needs read access to repository contents. No steps require write access to issues, pull requests, or repository contents.The best fix without changing functionality is to add a root-level
permissions:block immediately after thename:line, settingcontents: read. This will apply to all jobs (currently justtests) that do not overridepermissionsand will satisfy CodeQL’s requirement for explicit, least-privilege configuration. No imports or additional methods are needed because this is a YAML configuration change only.Concretely:
.github/workflows/tests_coverage.yml.1: name: Tests&Coverage, insert:This keeps the workflow behavior identical while ensuring the
GITHUB_TOKENcannot write to repository contents by default.Suggested fixes powered by Copilot Autofix. Review carefully before merging.