sharedManager renamed in sharedInstance to add compatibility to swift#89
Open
violabg wants to merge 1 commit intomariohahn:masterfrom
Open
sharedManager renamed in sharedInstance to add compatibility to swift#89violabg wants to merge 1 commit intomariohahn:masterfrom
violabg wants to merge 1 commit intomariohahn:masterfrom
Conversation
if you use this library in a swift project, you can't access MHGallerySharedManager.sharedManager(). The compiler complains because it can't see sharedManager. I looked around and find a fix thanks to this article http://justinmiller.io/posts/2015/01/28/swift-objc-initializers/ So if you rename sharedManager in sharedInstance you are able to access the singleton instance like this: MHGallerySharedManager.sharedInstance().webPointForThumb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if you use this library in a swift project, you can't access
MHGallerySharedManager.sharedManager().
The compiler complains because it can't see sharedManager.
I looked around and find a fix thanks to this article
http://justinmiller.io/posts/2015/01/28/swift-objc-initializers/
So if you rename sharedManager in sharedInstance you are able to access
the singleton instance like this:
MHGallerySharedManager.sharedInstance().webPointForThumb