Open
Conversation
The lower if-conditions were redundant and was performing the same as the upper if-conditions.
This acts like the ternary operator in other languages. It should hopefully increase the code readability.
This should increase code readability and help in catching mistyped values.
This should increase the readability and decrease the possibility that a value would be updated in one place but forgotten to be updated in another.
No use to repeat the statement twice if no need to.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Few general changes to the code before I started introducing our changes.
The last commit is basically few questions that I though it'd be easier to ask on the code itself, I'll remove that last commit later.
Fyi @marionbosc