fix: Change HashMap to BTreeMap for deterministic function ordering#6
Merged
marirs merged 1 commit intomarirs:masterfrom Mar 21, 2025
Merged
fix: Change HashMap to BTreeMap for deterministic function ordering#6marirs merged 1 commit intomarirs:masterfrom
marirs merged 1 commit intomarirs:masterfrom
Conversation
- This commit changes the data structure used for storing function candidates from HashMap to BTreeMap. Since BTreeMap maintains keys in sorted order, this ensures consistent function ordering across runs, fixing the issue where different numbers of functions were being returned on each execution. - Also fixes a critical bug in get_code_areas() where executable sections that were already aligned to 0x1000 bytes were being excluded from the results.
Owner
|
Thank you very much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nature of HashMap iteration ordering.