Modified the README.md to include a second example#40
Open
asparks1805 wants to merge 2 commits intomarkandrus:masterfrom
asparks1805:master
Open
Modified the README.md to include a second example#40asparks1805 wants to merge 2 commits intomarkandrus:masterfrom asparks1805:master
asparks1805 wants to merge 2 commits intomarkandrus:masterfrom
asparks1805:master
Conversation
Modified the README.md to include a second example where the account SID and auth token are embedded in the code rather than stored as environmental variables. This would allow a developer to compile a self-contained executable that could be run by end users without the need to create or understand environment variables. Also modified both examples to define sending and receiving phone number bindings to make it easier for the developer to read/configure.
| let body = PostMessage "+14158059869" "+14158059869" "Oh, hai" | ||
| let receivingPhone = "+14158059869" | ||
| let sendingPhone = "+14158059869" | ||
| let body = PostMessage receivingPhone sendingPhone "Oh, hai" |
Owner
There was a problem hiding this comment.
What do you think about using the names to and from instead of receivingPhone and sendingPhone? This would better match the REST API.
Author
There was a problem hiding this comment.
Yep, works for me. I'll make the change and update the pull request tomorrow morning.
Aaron
Cleared the review notes for commit 2afd62a (modified README for a second example). Modified the following: * Used to/from on phone bindings to match with Twilio's RESTful API * Alphabetized the imports * Used simpler Data.Text (Text) rather than qualified * Switched to 2 space indent from 4
Collaborator
|
@markandrus Hi Mark. It seems like this PR is over a year old. Would like to know if you want to update it and try to merge it into master, or if it is a good candidate for closing. (P.S., haven't actually looked at it, just the date it was opened). |
Owner
|
Sorry, I kind of dropped the ball on @asparks1805 PR. Some notes:
I'm also reminded of this suggestion to improve some of our examples. I don't think we should merge this as-is. Maybe we can run with some of the bullet points above, though? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the README.md to include a second example where the account SID and
auth token are embedded in the code rather than stored as environmental
variables. This would allow a developer to compile a self-contained executable
that could be run by end users without the need to create or understand
environment variables. Also modified both examples to define sending and
receiving phone number bindings to make it easier for the developer to
read/configure.
This change is