Minor updates - and remove body printing#66
Open
seanhess wants to merge 1 commit intomarkandrus:masterfrom
Open
Minor updates - and remove body printing#66seanhess wants to merge 1 commit intomarkandrus:masterfrom
seanhess wants to merge 1 commit intomarkandrus:masterfrom
Conversation
…and removed body printing
Owner
|
Thanks @seanhess, It looks like removing the Data.Monoid import broke some modules on older GHCs. I think we need to add it back. Otherwise, thanks for bumping containers and thanks for removing the print statement (definitely my mistake to have included it!). |
markandrus
requested changes
Feb 11, 2019
| let body = responseBody response | ||
| body' <- LBS.fromChunks <$> brConsume body | ||
| print body' | ||
| -- print body' |
| binary >=0.7, | ||
| bytestring ==0.10.*, | ||
| containers ==0.5.*, | ||
| containers >= 0.5.0 && <0.7.0, |
Owner
There was a problem hiding this comment.
I wonder if we can just nix the upper bound completely?
| import Control.Monad | ||
| import Control.Monad.Catch | ||
| import Data.Aeson | ||
| import Data.Monoid |
Owner
There was a problem hiding this comment.
I see some errors like
src/Twilio/Types/SID/TH.hs:59:6:
Not in scope: ‘<>’
Perhaps you meant one of these:
‘<$>’ (imported from Prelude), ‘*>’ (imported from Prelude),
‘<$’ (imported from Prelude)
So I think we need to add these imports back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated containers to be compatible with 0.5 and 0.6, then removed the Data.Monoid imports (no longer neccesary).
I removed the print statement in
runRequest', because it makes the library unusable (my programs log to stdout, so this means user information can become leaked to the logs.) I'd recommend leaving it out until you make it configurable. (Debug mode?)