Open
Conversation
Resolves markbates#635 by replacing mrjones/oauth with golang.org/x/oauth2, implementing PKCE required by X's Free tier API, and updating Session/Token structures accordingly.
Resolves markbates#635 by replacing mrjones/oauth with golang.org/x/oauth2, implementing PKCE required by X's Free tier API, and updating Session/Token structures accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #635
This PR addresses the issue where the
twitterv2provider was failing on X's Free Plan returning a401 Unauthorizeddue to its underlying usage of OAuth 1.0a.Changes made:
github.com/mrjones/oauthand migrated the provider entirely togolang.org/x/oauth2CodeVerifierand appending theoauth2.S256ChallengeOption()to ensure compatibility with X's API v2 requirements.Sessionstruct to use standard OAuth 2.0 fields (AccessToken,RefreshToken, etc.) instead of the legacy OAuth 1.0a tokens.providers/twitterv2/twitterv2_test.goandsession_test.go.This makes the
twitterv2provider functionally sound and compatible with modern X developer applications!