Fixing ConsistentHash hashing, lib versions and logging #6
Open
deniszh wants to merge 4 commits intomarkchadwick:masterfrom
Open
Fixing ConsistentHash hashing, lib versions and logging #6deniszh wants to merge 4 commits intomarkchadwick:masterfrom
deniszh wants to merge 4 commits intomarkchadwick:masterfrom
Conversation
NB: Latest Netty 3.8.0 is not in repo, please donload it separately and put netty.jar to ~/.ivy2/local/org.jboss.netty/netty/3.8.0.Final/jars/
Now its compatible with Graphite-web, so, metrics hit same carbon caches as Graphite-web, so we got cache-hit and metrics are reading from RAM instead of disk
I commented out "Invalid message" error - we got ton of them and provide (ugly) error handling when we got non-numeric value (we also got ton of them, its only put garbage in logs)
Author
|
PS: and I'm complete newbie in Scala, so, maybe my code is ugly, please bear with me. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I was able to successfully run graphite-relay on my testing Graphite environment with ~500K metrics/min with my changes below. Main change is Graphite-compatible hashing which provide good performance, since carbonlink requests from graphite-web hits proper carbon-caches now. Also I upgraded scopt and netty and make slight logging changes (we got many garbage from some agents, but maybe it's not an option for others)