Conversation
|
bugfix emtbView.mc |
markdotai
left a comment
There was a problem hiding this comment.
Hi :) I don't use GitHub much so not sure if reviewing this is the right thing to do ...
But I don't think this change can be correct: as if d==null, then when it tries to do !d.isConnected() it will crash (as d is null)
If this fixes something for you, then it is probably because d is never null (in your case) so it never calls bleDisconnect().
It may be a temporary fix for the Edge devices (if this is what it is for) to remove the test for !d.IsConnected(), and only test d==null. But that won't be valid for non-Edge devices. We could upload a temporary version of the app just for Edge devices to the Garmin app store though if it is useful for you?
|
Thanks for your reply. Indeed it's for edge, because i found that the original code disconnects immediately on Edge after connect. That's why i changed it, but obviously without overlooking the whole thing. What's the Edge specific behaviour here? |
|
I assume the Edge behavior is broken currently due to the firmware bug: https://forums.garmin.com/developer/connect-iq/i/bug-reports/bluetooth-ciq-datafield-break-in-fw-9-1 and when that is fixed then it will work ok again. |
No description provided.