Skip to content

Fix icy metadata title #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bastengao wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fix icy metadata title #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
61763c4
delete unused StreamingCore class
Jan 25, 2023
4d558fe
update kotlin version
markfili Jan 25, 2023
cf1571d
upgrade plugin version to v2.0.1
markfili Jan 25, 2023
6f13092
fix check for if default source is acc
markfili Jan 25, 2023
cf9d02a
upgrade plugin version to v2.0.2
markfili Jan 25, 2023
9577654
upgrade example dependencies
markfili Jan 28, 2023
013d218
fix fetching metadata for iOs build
markfili Jan 28, 2023
444fa6f
upgrade plugin version to v2.0.3
markfili Jan 28, 2023
e785250
upgrade Android build gradle, kotlin and dependencies versions
markfili Feb 2, 2023
61ed5f3
move player initialization before setting media sources, disable stop…
markfili Feb 2, 2023
78952a5
update plugin version
markfili Feb 2, 2023
69abc28
android - allow removing notification when playback paused, remove no…
markfili Feb 2, 2023
f808da0
reduce exoplayer dependencies to only needed ones
markfili Feb 2, 2023
30ded76
try to make sure the service and its player are initialized on every …
markfili Feb 2, 2023
e316f6c
upgrade plugin version to v2.2.0
markfili Feb 2, 2023
d1ecf26
Fix icy metadata title
bastengao Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
buildscript {

ext.kotlin_version = '1.5.32'
ext.exo_player_version = '2.18.1'
ext.kotlin_version = '1.8.0'
ext.exo_player_version = '2.18.2'

repositories {
google()
mavenCentral()
}

dependencies {
classpath 'com.android.tools.build:gradle:4.1.3'
classpath 'com.android.tools.build:gradle:7.4.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
}
}
Expand All @@ -29,7 +29,7 @@ apply plugin: 'com.android.library'
apply plugin: 'kotlin-android'

android {
compileSdkVersion 31
compileSdkVersion 33

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
Expand All @@ -56,10 +56,12 @@ dependencies {
implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'

implementation "org.greenrobot:eventbus:3.3.1"
implementation 'com.google.code.gson:gson:2.8.9'
implementation 'com.google.code.gson:gson:2.10.1'

implementation "androidx.multidex:multidex:2.0.1"

implementation "com.google.android.exoplayer:exoplayer:$exo_player_version"
implementation "com.google.android.exoplayer:exoplayer-core:$exo_player_version"
implementation "com.google.android.exoplayer:exoplayer-ui:$exo_player_version"
implementation "com.google.android.exoplayer:exoplayer-hls:$exo_player_version"
implementation "com.google.android.exoplayer:extension-mediasession:$exo_player_version"
}
1 change: 0 additions & 1 deletion android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
org.gradle.jvmargs=-Xmx1536M
android.enableR8=true
android.useAndroidX=true
android.enableJetifier=true
2 changes: 1 addition & 1 deletion android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.1.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-all.zip
9 changes: 6 additions & 3 deletions ...main/kotlin/me/sithiramunasinghe/flutter/flutter_radio_player/FlutterRadioPlayerPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ class FlutterRadioPlayerPlugin : FlutterPlugin, ActivityAware, MethodChannel.Met
Log.i(TAG, "::: Attaching to FRP to FlutterEngine :::")
this.context = context
frpChannel = MethodChannel(binaryMessenger, METHOD_CHANNEL_NAME)
frpChannel?.setMethodCallHandler(this)

val eventChannel = EventChannel(binaryMessenger, EVENT_CHANNEL_NAME)
eventChannel.setStreamHandler(object : EventChannel.StreamHandler {
Expand Down Expand Up @@ -121,15 +120,18 @@ class FlutterRadioPlayerPlugin : FlutterPlugin, ActivityAware, MethodChannel.Met
isBound = false
}
}
Log.i(TAG, "Binding service...")
flutterPluginBinding?.applicationContext?.bindService(serviceIntent, serviceConnection!!, Context.BIND_AUTO_CREATE)

context.bindService(serviceIntent, serviceConnection!!, Context.BIND_AUTO_CREATE)
frpChannel?.setMethodCallHandler(this)
}

@Subscribe(threadMode = ThreadMode.MAIN)
fun handleFRPEvents(event: FRPPlayerEvent) {
if (eventSink != null) {
Log.d(TAG, "FRP Event data = $event")
if (event.playbackStatus != null) {
// TODO reconsider unbinding service on stop because it might be too cumbersome to rebind it when resuming
if (event.playbackStatus == FRP_STOPPED) {
Log.i(TAG, "Service unbind....")
isBound = false
Expand All @@ -152,6 +154,7 @@ class FlutterRadioPlayerPlugin : FlutterPlugin, ActivityAware, MethodChannel.Met
}

override fun onMethodCall(call: MethodCall, result: MethodChannel.Result) {
Log.i(TAG, ":::: received method call: ${call.method} ::::")
when (call.method) {
"init_service" -> {
if (isBound) {
Expand Down Expand Up @@ -219,7 +222,7 @@ class FlutterRadioPlayerPlugin : FlutterPlugin, ActivityAware, MethodChannel.Met
}
"seek_source_to_index" -> {
if (!isBound) {
result.error("FRP_008", "Failed to call prev_source", null)
result.error("FRP_008", "Failed to call seek_source_to_index", null)
throw FRPException("FRPCoreService has not been initialized yet")
}
val sourceIndex: Int = call.argument<Int>("source_index") ?: 0
Expand Down
Loading