Skip to content

Conversation

rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Aug 29, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings August 29, 2025 18:09
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Jenkins build issues for Java 21 by configuring Gradle toolchain settings. The changes add custom Java installation paths to help Gradle locate the required Java versions during the build process.

  • Adds Gradle toolchain configuration to specify custom Java installation locations
  • Configures environment variable detection for Java installations
  • Sets explicit paths for JDK 17 and JDK 21 installations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.


# See https://docs.gradle.org/current/userguide/toolchains.html#sec:custom_loc for information
# on custom toolchain locations in Gradle. Adding these to try to make Jenkins happy.
org.gradle.java.installations.fromEnv=JAVA_HOME_DIR
Copy link
Preview

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable name 'JAVA_HOME_DIR' is non-standard. The conventional environment variable for Java home is 'JAVA_HOME'. Using 'JAVA_HOME_DIR' may cause Gradle to not detect the Java installation correctly.

Suggested change
org.gradle.java.installations.fromEnv=JAVA_HOME_DIR
org.gradle.java.installations.fromEnv=JAVA_HOME

Copilot uses AI. Check for mistakes.

@rjrudin rjrudin merged commit f21157b into develop Aug 29, 2025
2 checks passed
@rjrudin rjrudin deleted the feature/java21-fix branch August 29, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants