Skip to content

MLE-23230 Tweaking retry interceptor #1821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2025
Merged

MLE-23230 Tweaking retry interceptor #1821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion marklogic-client-api/src/main/java/com/marklogic/client/impl/okhttp/RetryInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@ private boolean isRetryableException(IOException e) {
e.getMessage().contains("Failed to connect") ||
e.getMessage().contains("unexpected end of stream") ||
e.getMessage().contains("Connection reset") ||
e.getMessage().contains("Read timed out")
e.getMessage().contains("Read timed out") ||
e.getMessage().contains("Broken pipe")
Comment on lines 68 to +72
Copy link
Preview

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String-based exception detection is fragile and error-prone. Consider checking exception types (e.g., SocketException, ConnectException) or using more specific exception handling instead of relying on error message text matching.

Copilot uses AI. Check for mistakes.

));
}

Expand Down