fixes, need to check #41
Conversation
-Apply angular momentum based on part CoM not part center -Store and apply angular velocity at next FixedUpdate -Change some calculations to use doubles Note: still needs angular momentum fix for stretched joints
…owing down after warp because joints got unstretched while on rails.
…o settle before applying new momentum. Fix going off rails restoring vessel angular velocity to lower than before when the vessel's angular velocity was maxed out: temporarily increase rigidbody maximum angular velocity and then restore it 10 frames later.
markusa380
left a comment
markusa380
left a comment
There was a problem hiding this comment.
Looks good to me.
Lets see if someone else can check who has more recent C# experience.
|
Can you rebase? |
|
I'm sorry. I was starting an adoption process of this, I didn't mean to send this to you. You haven't been around for a year, so I figured I'd get it updated and supported. Let me know if you are intending to continue. I've merged and tested all the changes on my system, am working on removing all the blizzy and stock toolbar code and using the ToolbarController instead. simplifies the whole process. I'm going to close this, if you do want to continue and want my changes, let me know and I'll do a push back once I'm done. |
|
@linuxgurugamer I have always been open for people to contribute to this, I don't actively contribute code anymore, but I do still maintain the repo and forum posts. |
|
I've submitted a new PR for all the changes |
Are you going to do anything? You still haven't been on the forum, and I've heard no response from you about the new PR I submitted. |
3 participants
@Virindi-AC
Fix orbit change on going off rails: …
1525e35
@Virindi-AC
Store angular momentum rather than velocity. This fixes the vessel sl… …
9b59c2b
@Virindi-AC
Fix slower rotation on game load: wait 3 ticks for the vessel's MOI t… …