Open
Conversation
- Previously dense observation types are now entered as a single observation in the Annotation observation list, they no longer redefine the observation list itself, rather, just the elements within it. This means that all Annotations now have a list of observations, the elements of which can be dense observations themselves - the import_labs function has been moved from the util module to the core module. In a future PR it should be modified to be a constructor for JObjects - Fixed serialization JAMs for bools, lists and dicts - Updated jsonschema to latest version - necessary for determining namespaces based on a const namespace property - Local namespaces are no longer supported - a necessity to become jsonschema compliant - Version bumped - Tests updated to adhere to new schema for objects with DenseObservations - Removed spurious validation and __schema__ methods / attributes in jams.core module - add_namespace and is_dense is removed from the jams.schema module. All namespaces are now available in the jams.schema.NAMESPACES dictionary - schema for each observation type is now available in the jams.schema.OBSERVATIONS_SCHEMA dictionary
Contributor
|
Hey! Is this in response to an issue? Was there a side convo I’m missing? |
Contributor
Member
@MCMcCallum and I had actually hashed this out quite a bit before the implementation, but it was out-of-band. Sorry that I haven't had time to dig into this PR thoroughly btw. Teaching in a pandemic, you know 😬
The plan in #208 , phase 1, is to retain backward compatibility to the previous schema. However, dynamic namespace support will eventually dropped, and scaper will likely need to adapt in response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.