Skip to content

Implement getenv for non-Windows OSes #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgord9518 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement getenv for non-Windows OSes #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/cstd.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,24 @@ export fn abort() callconv(.C) noreturn {

// TODO: can name be null?
// TODO: should we detect and do something different if there is a '=' in name?
export fn getenv(name: [*:0]const u8) callconv(.C) ?[*:0]u8 {
trace.log("getenv {}", .{trace.fmtStr(name)});
return null; // not implemented
//const name_len = std.mem.len(name);
//var e: ?[*:0]u8 = environ;
export fn getenv(key: [*:0]const u8) callconv(.C) ?[*:0]u8 {
trace.log("getenv {}", .{trace.fmtStr(key)});
switch (builtin.os.tag) {
// Windows not yet implemented
// Maybe `environ` should be populated on the first call of getenv?
.windows => return null,
else => {
// Looking at the Zig stdlib implementation of getenvZ, this should
// be null terminated
const ret = std.os.getenvZ(key);
if (ret) |env| {
// Why does libc return a mutable pointer with getenv?
return @constCast(env[0.. :0].ptr);
}

return null;
},
}
}

export fn system(string: ?[*:0]const u8) callconv(.C) c_int {
Expand Down