-
Notifications
You must be signed in to change notification settings - Fork 0
feat: encrypted backup subcommand (age + VACUUM INTO) #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
15ae62f
feat: add internal/backup package with filippo.io/age
marlian c5bb645
feat: backup subcommand; export mcpserver.ResolveDBPath
marlian ce7320f
docs: backup section, Step 3.4, decision entry
marlian 1191963
review: address Copilot review feedback on PR #6
marlian 797749e
review: address Copilot round 2 feedback on PR #6
marlian f7767f7
review: address Copilot round 3 feedback on PR #6
marlian 82aae9b
review: tighten ParseRecipients error handling
marlian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backup.ParseRecipientstakes a[]string, butrecipientshere is a named slice type (recipientFlag). As written,backup.ParseRecipients(recipients)won’t compile; convert it explicitly (e.g., to the underlying[]string) or changeParseRecipientsto accept the named type/interface.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does compile — Go's assignability rules allow passing a named slice type where the parameter type is the underlying unnamed slice type. From the spec: "A value x of type V is assignable to a variable of type T if V and T have identical underlying types and at least one of V or T is not a named type." Here V is
recipientFlag(named, underlying[]string) and T is[]string(unnamed), so the call is valid without an explicit conversion. Empirical proof:Test (ubuntu-latest / macos-latest / windows-latest)and all five cross-build jobs on this branch's HEAD are green, andgo build ./...succeeds locally. I'd rather keep the call site natural than add a cosmetic conversion.