#57 Fix for..in bug, add tests to guard against regressions.#58
#57 Fix for..in bug, add tests to guard against regressions.#58RichardBradley wants to merge 2 commits intomarmelab:masterfrom
Conversation
|
(This is rather ugly, but I think it is necessary. If we had "angular" in scope then a most of these could be fixed with "angular.foreach", but admin-config doesn't currently have angular as a dependency.) |
The former causes "ReferenceError: Symbol is not defined" in ng-admin.
|
I found that using "for .. of" breaks ng-admin with "ReferenceError: Symbol is not defined" errors, so I've removed that from this PR. |
|
Any thoughts on this? |
|
Any update on this one? Do you not like the "for..in" syntax? It is ugly, but I think it is necessary, as demonstrated above. If you don't want to make this change, I understand. |
|
Sorry about that. The PR looks fine to me expect it needs to be rebased. |
|
From my point of view, this is ready to merge. I won't rebase it myself, as I am not confident that it would get merged were I to spend that time. It should be only a few minutes work to rebase & fix the conflicts if anyone with write permission wanted to do so. |
This fixes #57, and adds tests which a) demonstrate why this is required and b) should guard against regressions.