Update for compatibility with latest WireShark, and fix MSTNAK handling bug#5
Open
dchauran wants to merge 2 commits intomarrold:masterfrom
Open
Update for compatibility with latest WireShark, and fix MSTNAK handling bug#5dchauran wants to merge 2 commits intomarrold:masterfrom
dchauran wants to merge 2 commits intomarrold:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the existing code mostly works in the current version of WireShark there are a few issues that either cause errors or outright break some scenarios.
info(). This was causing failures with MSTNAK packet processing. The fix is to useprint().math.pow(), causing errors in calculating BER. The fix is to use^instead.