Conversation
Updates CI, makes it more simpler
There was a problem hiding this comment.
Pull Request Overview
This pull request dramatically simplifies the GitHub Actions CI workflows by removing most quality assurance and validation steps, keeping only basic build functionality. The change reduces CI complexity but significantly decreases code quality enforcement and cross-platform validation.
- Removed all testing, linting (clippy), and formatting (rustfmt) checks from both workflows
- Eliminated multi-platform build matrix that previously built and tested on Ubuntu, Windows, and macOS
- Removed path-based trigger filters, causing workflows to run on all changes regardless of relevance
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/quantadb-server.yml |
Simplified from comprehensive CI with tests, linting, formatting, and multi-OS builds to Ubuntu-only build |
.github/workflows/client-cli.yml |
Simplified from comprehensive CI with tests, linting, formatting, and multi-OS builds to Ubuntu-only build |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| - name: Run clippy | ||
| run: cd server && cargo clippy -- -D warnings | ||
|
|
||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
The workflow is missing Rust toolchain installation. Add a step to install Rust using dtolnay/rust-toolchain@stable before the build step to ensure consistent build environment.
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@stable |
| - name: Run clippy | ||
| run: cd cli-client && cargo clippy -- -D warnings | ||
|
|
||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
The workflow is missing Rust toolchain installation. Add a step to install Rust using dtolnay/rust-toolchain@stable before the build step to ensure consistent build environment.
| - uses: actions/checkout@v4 | |
| - uses: actions/checkout@v4 | |
| - uses: dtolnay/rust-toolchain@stable |
This pull request significantly simplifies the GitHub Actions CI workflows for both the CLI client and the server. The workflows have been refactored to focus solely on building the respective components on Ubuntu, removing all test, lint, formatting, and multi-OS build steps. This change streamlines CI but also reduces coverage and validation.
Workflow simplification:
.github/workflows/client-cli.ymland.github/workflows/quantadb-server.ymlworkflows have been refactored to only run a single build job onubuntu-latest, removing all test, lint (clippy), formatting (rustfmt), and multi-platform build matrix steps. Only the build step remains for each. [1] [2]Trigger configuration changes:
pathsfilters, so workflows will now run on all pushes and pull requests tomain, regardless of which files are changed. [1] [2]