Skip to content

Develop#6

Merged
martian56 merged 2 commits intomainfrom
develop
Sep 30, 2025
Merged

Develop#6
martian56 merged 2 commits intomainfrom
develop

Conversation

@martian56
Copy link
Copy Markdown
Owner

This pull request significantly simplifies the GitHub Actions CI workflows for both the CLI client and the server. The workflows have been refactored to focus solely on building the respective components on Ubuntu, removing all test, lint, formatting, and multi-OS build steps. This change streamlines CI but also reduces coverage and validation.

Workflow simplification:

  • The .github/workflows/client-cli.yml and .github/workflows/quantadb-server.yml workflows have been refactored to only run a single build job on ubuntu-latest, removing all test, lint (clippy), formatting (rustfmt), and multi-platform build matrix steps. Only the build step remains for each. [1] [2]

Trigger configuration changes:

  • The workflow triggers have been simplified by removing the paths filters, so workflows will now run on all pushes and pull requests to main, regardless of which files are changed. [1] [2]

@martian56 martian56 self-assigned this Sep 30, 2025
@martian56 martian56 added bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request labels Sep 30, 2025
@martian56 martian56 merged commit 45a5b84 into main Sep 30, 2025
3 checks passed
@martian56 martian56 requested a review from Copilot October 1, 2025 18:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request dramatically simplifies the GitHub Actions CI workflows by removing most quality assurance and validation steps, keeping only basic build functionality. The change reduces CI complexity but significantly decreases code quality enforcement and cross-platform validation.

  • Removed all testing, linting (clippy), and formatting (rustfmt) checks from both workflows
  • Eliminated multi-platform build matrix that previously built and tested on Ubuntu, Windows, and macOS
  • Removed path-based trigger filters, causing workflows to run on all changes regardless of relevance

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/quantadb-server.yml Simplified from comprehensive CI with tests, linting, formatting, and multi-OS builds to Ubuntu-only build
.github/workflows/client-cli.yml Simplified from comprehensive CI with tests, linting, formatting, and multi-OS builds to Ubuntu-only build

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

- name: Run clippy
run: cd server && cargo clippy -- -D warnings

- uses: actions/checkout@v4
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is missing Rust toolchain installation. Add a step to install Rust using dtolnay/rust-toolchain@stable before the build step to ensure consistent build environment.

Suggested change
- uses: actions/checkout@v4
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable

Copilot uses AI. Check for mistakes.
- name: Run clippy
run: cd cli-client && cargo clippy -- -D warnings

- uses: actions/checkout@v4
Copy link

Copilot AI Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is missing Rust toolchain installation. Add a step to install Rust using dtolnay/rust-toolchain@stable before the build step to ensure consistent build environment.

Suggested change
- uses: actions/checkout@v4
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation duplicate This issue or pull request already exists enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants