Draft: Issue-849 Add ability to provide method to override WriteMessage #850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass XUnitLogger into WriteMethodOverride add more tests change formatter name
Owner
Let me know when you get the green light, then I'll take a look at the PR properly. I've moved it to draft. I just did a quick skim read for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #850 +/- ##
==========================================
+ Coverage 98.53% 98.59% +0.05%
==========================================
Files 15 15
Lines 273 284 +11
Branches 36 39 +3
==========================================
+ Hits 269 280 +11
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #849 and #451
This PR adds the ability to override the WriteMessage method of XUnitLogger by providing a delegate in XUnitLoggerOptions.
The XUnitLogger is passed into the delegate so that it is possible to access properties of the logger such as the log category (XUnitLogger.Name).
Note: I need to wait for approval to contribute to open source from my organisation so please don't merge this yet.