Feature: add logistic regression and multiple regression as options by martinctc · Pull Request #7 · martinctc/rwa

martinctc · 2021-02-27T21:46:13Z

Summary

This branch adds logistic regression and multiple regression as additional options. This version is incremented to 0.1.2.9000 as the development version (not submitted to CRAN).

The changes made in this PR are:

Core functions: Created rwa_logit() for binary outcomes (logistic regression) and rwa_multiregress() for continuous outcomes (multiple regression)
Wrapper function: Converted rwa() to automatically detect method based on outcome variable (2 unique values → logistic, otherwise → multiple regression) with explicit method parameter override
API standardization: Unified output structure across both methods (consistent column naming, rescaled weights sum to 100, lambda matrices)
Numerical stability: Added safeguards in rwa_logit() for edge cases (clipping predictions away from 0/1, zero standard deviation handling)
Documentation: Added comprehensive roxygen2 docs with examples for both functions and new "Regression Methods" vignette
Plotting support: Extended plot_rwa() to handle both regression types with appropriate labeling
Test coverage: Added test suites for logistic regression, integration tests, and validation of numerical edge cases

Usage example:

# Automatic detection - binary outcome uses logistic regression
mtcars$high_mpg <- ifelse(mtcars$mpg > median(mtcars$mpg), 1, 0)
rwa(mtcars, "high_mpg", c("cyl", "disp", "hp", "wt"))

# Automatic detection - continuous outcome uses multiple regression  
rwa(mtcars, "mpg", c("cyl", "disp", "hp", "wt"))

# Explicit method selection
rwa(mtcars, "high_mpg", c("cyl", "disp", "hp", "wt"), method = "logistic")

Check

All R CMD checks pass
roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.

- `rwa_multiregress()` is created as a duplicate of the original `rwa()`. - `rwa()` is used as a wrapper to call `rwa_multiregress()` and `rwa_logit()`

Copilot

Pull request overview

This pull request adds support for logistic regression alongside the existing multiple regression functionality in the relative weights analysis (RWA) package. The changes refactor the original rwa() function into specialized implementations and convert it to a wrapper that automatically detects the appropriate regression method.

Changes:

Created rwa_multiregress() containing the original multiple regression implementation
Created rwa_logit() implementing logistic regression for binary outcomes
Converted rwa() into a wrapper function with automatic method detection based on outcome variable

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 22 comments.

Show a summary per file

File	Description
R/rwa.R	Refactored into wrapper function with method routing logic and automatic binary outcome detection
R/rwa_multiregress.R	Extracted original multiple regression implementation with full import statements
R/rwa_logit.R	New logistic regression implementation using SVD decomposition approach
man/rwa.Rd	Updated documentation with new `method` parameter and logistic regression examples
man/rwa_multiregress.Rd	Documentation for extracted multiple regression function
man/rwa_logit.Rd	Documentation for new logistic regression function
NAMESPACE	Added exports for new `rwa_logit` and `rwa_multiregress` functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

R/rwa_logit.R

R/rwa_multiregress.R

R/rwa_logit.R

R/rwa_multiregress.R

R/rwa.R

R/rwa_logit.R

…in rwa_logit() and rwa_multiregress()

…gress and rwa_logit

…date labels

…stic RWA

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

R/rwa_logit.R

Copilot · 2026-01-21T16:04:09Z

R/rwa_logit.R

+               Rescaled.RelWeight = PropWeights) %>%
+    mutate(Sign = sign)
+
+  complete_cases <- nrow(drop_na(thedata))


Missing tidyr namespace prefix. Line 18 uses 'tidyr::drop_na()', but this line uses 'drop_na()' without the namespace prefix. Use 'tidyr::drop_na()' for consistency.

Suggested change

complete_cases <- nrow(drop_na(thedata))

complete_cases <- nrow(tidyr::drop_na(thedata))

tests/testthat/test-plot_rwa.R

R/rwa_logit.R

tests/testthat/test-rwa.R

R/rwa_logit.R

tests/testthat/test-rwa.R

R/rwa_multiregress.R

…egress functions

…ons with examples and additional output details

…it and rwa_multiregress functions

…n plot_rwa function

…do R-squared and Lambda matrix

…to sum to 100%

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Complete the documentation for the lambda return value, explaining that it is the transformation matrix mapping original correlated predictors to orthogonal variables while preserving their relationship to the outcome.

…martinctc/rwa into feature/add-logistic-regression

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

R/rwa_multiregress.R

vignettes/regression-methods.Rmd

R/rwa_logit.R

vignettes/regression-methods.Rmd

R/plot_rwa.R

tests/testthat/test-rwa.R

R/rwa.R

R/rwa_logit.R

NEWS.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Address code review feedback for API consistency and documentation: - rwa_logit: Use 'Variables' column name (matching rwa_multiregress) - rwa_logit: Use the existing Variables variable instead of 'predictors' - rwa_multiregress: Fix docs to reference rwa_multiregress() not rwa() - plot_rwa: Remove lambda fallback in caption (lambda is a matrix, not scalar) - vignette: Fix iris_logit\ to iris_logit\ (pseudo R-squared) - test-rwa: Fix incorrect comment (logistic regression does return rsquare) This ensures consistent API across both regression methods and accurate documentation throughout the package.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 11 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

R/rwa_logit.R

tests/testthat/test-rwa.R

R/plot_rwa.R

R/rwa_logit.R

vignettes/regression-methods.Rmd

tests/testthat/test-rwa.R

R/rwa_logit.R

Code quality: Add dplyr:: prefix to select/mutate, stats:: to sd. Remove extraneous blank lines in test-rwa.R. Numerical stability: Clamp predicted probabilities to avoid Inf/-Inf in logit transformation. Add warning and fallback for zero stddev (perfect separation).

- rwa_logit: Write specific description instead of inheriting from rwa() - plot_rwa: Simplify comment (both functions now use Variables column) - vignette: Remove README-specific fig.path parameter

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

vignettes/regression-methods.Rmd

R/rwa.R

R/rwa_logit.R

R/rwa_multiregress.R

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

martinctc · 2026-01-22T10:58:35Z

@copilot Can you help summarise the changes in this PR in a numbered bulleted list?

Copilot · 2026-01-22T10:58:46Z

@martinctc I've opened a new pull request, #23, to work on those changes. Once the pull request is ready, I'll request review from you.

…ives

martinctc · 2026-01-22T12:16:41Z

All checks passing - merging 0.1.2.9000 into main now.

feat: create rwa_logit

8dcc3fb

martinctc self-assigned this Feb 27, 2021

martinctc added the enhancement New feature or request label Feb 27, 2021

martinctc added 2 commits February 27, 2021 23:01

feat: create rwa_multiregress()

b39e604

- `rwa_multiregress()` is created as a duplicate of the original `rwa()`. - `rwa()` is used as a wrapper to call `rwa_multiregress()` and `rwa_logit()`

docs: improve wrapper documentation

a4fe972

martinctc mentioned this pull request May 19, 2021

rwa for logistic regression #11

Closed

martinctc mentioned this pull request Dec 10, 2023

weights and missings #12

Open

martinctc requested a review from Copilot January 20, 2026 12:05

Copilot started reviewing on behalf of martinctc January 20, 2026 12:06 View session

Copilot AI reviewed Jan 20, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 21, 2026

Add weight variable and missing data handling options to rwa() #22

Open

9 tasks

martinctc added 11 commits January 21, 2026 11:01

Merge branch 'master' into feature/add-logistic-regression

029a568

feat: clean up parameters on rwa_logit() and rwa_multiregress()

e951272

test: enhance coverage on new logit and regression functions

0f97497

feat: update data selection to use all_of for outcome and predictors …

bfbc22c

…in rwa_logit() and rwa_multiregress()

chore: add missing imports

5e35694

docs: remove problematic medium link failing R-CMD-checks

0e0c53e

feat: update reference section in _pkgdown.yml to include rwa_multire…

20fda7d

…gress and rwa_logit

feat: enhance plot_rwa() to handle y-axis limits based on sign and up…

09056ed

…date labels

feat: add vignette for regression methods including multiple and logi…

2170e8e

…stic RWA

chore: bump version to v0.1.2.9000

2c9b032

docs: update NEWS.md

a69a04b

martinctc requested a review from Copilot January 21, 2026 15:54

Copilot started reviewing on behalf of martinctc January 21, 2026 15:55 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

martinctc added 5 commits January 21, 2026 16:10

refactor: remove unused variable numVar from rwa_logit and rwa_multir…

df427dd

…egress functions

docs: enhance documentation for rwa_logit and rwa_multiregress functi…

35f0743

…ons with examples and additional output details

fix: specify tidyr::drop_na for complete cases calculation in rwa_log…

22849b0

…it and rwa_multiregress functions

fix: handle variable name extraction for different regression types i…

3a707ac

…n plot_rwa function

docs: update return values in rwa_logit documentation to clarify pseu…

20afed4

…do R-squared and Lambda matrix

martinctc and others added 6 commits January 21, 2026 17:06

fix: update Rescaled.RelWeight representation in logistic regression …

7d30e5e

…to sum to 100%

chore: correct indentation

fad0116

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: properly import NAMESPACE

100d522

chore: update opening brace style

e596154

docs: add lambda return value description in rwa_multiregress

d191712

Complete the documentation for the lambda return value, explaining that it is the transformation matrix mapping original correlated predictors to orthogonal variables while preserving their relationship to the outcome.

Merge branch 'feature/add-logistic-regression' of https://github.com/…

30115e5

…martinctc/rwa into feature/add-logistic-regression

martinctc marked this pull request as ready for review January 21, 2026 17:46

martinctc requested a review from Copilot January 21, 2026 17:47

Copilot started reviewing on behalf of martinctc January 21, 2026 17:48 View session

Copilot AI reviewed Jan 21, 2026

View reviewed changes

martinctc and others added 2 commits January 21, 2026 17:58

docs: Update NEWS.md

73d2200

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

martinctc requested a review from Copilot January 22, 2026 09:36

Copilot started reviewing on behalf of martinctc January 22, 2026 09:36 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

martinctc added 2 commits January 22, 2026 10:32

docs: improve documentation accuracy and consistency

043125e

- rwa_logit: Write specific description instead of inheriting from rwa() - plot_rwa: Simplify comment (both functions now use Variables column) - vignette: Remove README-specific fig.path parameter

martinctc requested a review from Copilot January 22, 2026 10:36

Copilot started reviewing on behalf of martinctc January 22, 2026 10:36 View session

Copilot AI reviewed Jan 22, 2026

View reviewed changes

martinctc and others added 3 commits January 22, 2026 10:42

chore: remove whitespace

5ed0f57

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor: align to R best practices for assignment

6f8379e

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chore: cosmetic change on variable names

5d49b18

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Jan 22, 2026

Feature: add logistic regression and multiple regression as options #23

Closed

9 tasks

fix: add missing global variable 'variable_name' to avoid false posit…

c71529b

…ives

martinctc merged commit e13908a into master Jan 22, 2026
3 checks passed

martinctc deleted the feature/add-logistic-regression branch January 22, 2026 12:16

	complete_cases <- nrow(drop_na(thedata))
	complete_cases <- nrow(tidyr::drop_na(thedata))

Conversation

martinctc commented Feb 27, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Check

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

martinctc commented Jan 22, 2026

Uh oh!

Copilot AI commented Jan 22, 2026

Uh oh!

martinctc commented Jan 22, 2026

martinctc commented Feb 27, 2021 •

edited

Loading